Python 3 persistent_hash was broken. Go back to builtin hash instead. #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying the examples/util/estimate_pi.py example on a Python 3 Disco installation and it was failing in a call to persistent_hash because it was trying to run str_to_bytes on an integer and failing because it has no 'encode' method.
I see from the discussion groups that at least one other person has had a problem with this persistent_hash.
Having looked at it I can't see any reason why the Python 3 code can't use the builtin 'hash' function just like the Python 2 code does.
It's hard so second guess the reason as to why the persistent_hash function was added. At least as far as the estimate_pi example goes I get an answer instead of an exception (as long as I fix the print statement at the bottom of the file).
Giles