add rejectUnauthorized flag #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added rejectUnauthorized flag true by default
Update authorizer.js
| @@ -85,6 +85,7 @@ _.extend(Authorizer.prototype, { | |||
| url: this.config.authEndpoint, | |||
| form: postData, | |||
| auth: auth, | |||
| rejectUnauthorized: (this.config.rejectUnauthorized == null ? true : this.config.rejectUnauthorized), | |||
There was a problem hiding this comment.
Please use strict comparison (===)
|
Hi @tbass134 Can you please update these 2 things before I merge the changes?
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to add the rejectUnauthorized flag in the authorize request.
In my usage, we connect to a Pusher server in an dev environment. However, when trying to connect, the pusher connection error's out:
Couldn't get auth info from your webapp Host: XX. is not in the cert's altnames:More detail of this issue is found here:
request/request#1777
This update is to allow to connect to an invalid certificate for development.
If not set,
rejectUnauthorizedwill be true(which is the default)