fix: remove try block #949
Open
+8
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`try {} except e {}` is now deprecated (elvish v0.18.0) and will be
removed in the next version - 0.19.0.
Since direnv will most probably run in pre-0.18.0 elvish
environments it is maybe for the best to remove the try block.
As far as I can see - its use is to catch exceptions from running
`direnv export elvish`, which should only happen if direnv vanishes
from the user's path. Any other error should most probably fail
anyway, rather than echo the exception but proceed.
|
If I direnv: error /tmp/.envrc is blocked. Run `direnv allow` to approve its content
[&reason=[&cmd-name=/opt/homebrew/bin/direnv &exit-status=1 &pid=96438 &type=external-cmd/exited]]now I get direnv: error /tmp/.envrc is blocked. Run `direnv allow` to approve its content
Exception: /opt/homebrew/bin/direnv exited with 1
/Users/avioli/.config/elvish/lib/direnv.elv, line 3: var m = [("/opt/homebrew/bin/direnv" export elvish | from-json)]but at the end - the change of the directory is not prevented. |
|
@icidasset @mmlb do you have any opinion on this PR? |
|
Hmm I get that it doesn't really matter that the exception is not caught but it's not something I'd like to do if this were my project. Why not just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try {} except e {}is now deprecated (elvish v0.18.0) and will be removed in the next version - 0.19.0.Since direnv will most probably run in pre-0.18.0 elvish environments it is maybe for the best to remove the try block.
As far as I can see - its use is to catch exceptions from running
direnv export elvish, which should only happen if direnv vanishes from the user's path. Any other error should most probably fail anyway, rather than echo the exception but proceed.