New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract comments to a separate table #22295
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: a7aaf23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 23 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have some form of timeout on migrations? if so then this loop may run into that for larger projects 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, there isn't. CC @wrynegade
Co-authored-by: Brainslug <br41nslug@users.noreply.github.com>
Co-authored-by: Brainslug <br41nslug@users.noreply.github.com>
Scope
What's changed:
directus_comments
table for commentsPotential Risks / Drawbacks
Review Notes / Questions
comment
field is now a required field/activity/comment
API, should an error message similar to the one in webhooks be added?directus/api/src/controllers/webhooks.ts
Line 19 in d8c544e
Related to #17894