Allow creating new bookmark when there are no existing bookmarks #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes early return from the set_autojoin function to allow creating a new bookmark (with add_conference function).
|
Thanks for your PR. Did you test this change with legacy bookmarks (xep 0048) or bookmarks2 (xep 402)? I see one issue with this change in combination with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently first-time join (with an invite and without any bookmarks) fails to create a new bookmark for a conversation due to early return in the
set_autojoinfunction.This PR removes early return to allow the call to the
add_conferencefunction (to create a new bookmark).