Attempt to not display revoked keys

[cjj20]

This is my attempt to not display revoked keys.

[cjj20]

@fiaxh please review

[fiaxh]

Please compile your code and test it before submitting it - this code doesn't even compile.

It also needs lots of cleanup, for example you shouldn't add random commented-out code.

[cjj20]

Please compile your code and test it before submitting it - this code doesn't even compile.

It also needs lots of cleanup, for example you shouldn't add random commented-out code.

Hi, my apologies and I have compiled but would like to try a new approach. That is using the Gtk.ListStore.remove function along with the gpgme boolean Revoked. I may alternatively grayout the revoked keys.

[cjj20]

Please compile your code and test it before submitting it - this code doesn't even compile.

It also needs lots of cleanup, for example you shouldn't add random commented-out code.
Improvement made, compiles and hides the revoked keys but only when freshly built. When closed then reopened, revoked keys shows up again. New PR contains changes #1572

[eerielili]

hello @cjj20

Improvement made, compiles and hides the revoked keys but only when freshly built. When closed then reopened, revoked keys shows up again

I suggest you have a look at #1540 and this snippet:

dino/plugins/openpgp/src/gpgme_helper.vala

Lines 104 to 131 in 779092c

	public static Gee.List<Key> get_keylist(string? pattern = null, bool secret_only = false) throws GLib.Error {
	global_mutex.lock();
	try {
	initialize();
	Gee.List<Key> keys = new ArrayList<Key>();
	Context context = Context.create();
	context.op_keylist_start(pattern, secret_only ? 1 : 0);
	try {
	while (true) {
	Key key = context.op_keylist_next();
	if (!key.expired && !key.revoked){
	debug("PGP Key " + key.fpr + " is valid!");
	keys.add(key);
	}
	else {
	debug("PGP Key " + key.fpr + " is either expired or revoked!");
	}
	}
	} catch (Error e) {
	if (e.code != GPGError.ErrorCode.EOF) throw e;
	}
	context.op_keylist_end();
	return keys;
	} finally {
	global_mutex.unlock();
	}
	}

Putting the check for expired or revoked GPG keys in the get_keylist function does help not showing them ever again after restarting Dino.

Kinds regards,
lili