Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow blocking entire domain from conversation details #1493

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eerielili
Copy link
Contributor

@eerielili eerielili commented Oct 9, 2023

Might close #1429.
I tested it on my end, works well. Might look around for less lines of code, still a WIP.
image

When domain is blocked:
image

Don't hesitate to give me feedback.

@pravi
Copy link

pravi commented Oct 25, 2023

I have tested it on Purism Librem 5 (debs here https://people.debian.org/~praveen/mobian/), it is not adaptive, please use libadwaita widgets to make it adaptive. arrange the buttons vertically.

Screenshot from 2023-10-25 17-40-45

@pravi
Copy link

pravi commented Oct 25, 2023

When I have multiple accounts, it does not show which account I'm using.

@eerielili
Copy link
Contributor Author

eerielili commented Oct 29, 2023

When I have multiple accounts, it does not show which account I'm using.

I partly addressed it in #1482, I'll do a separate one with a line of text underneath the contact's avatar in conversation settings indicating which account is used.

I have tested it on Purism Librem 5 (debs here https://people.debian.org/~praveen/mobian/), it is not adaptive, please use libadwaita widgets to make it adaptive. arrange the buttons vertically.

Screenshot from 2023-10-25 17-40-45

I have force pushed a fix to my branch so that the button goes on a new line. Could have calculated the root window width, stored it, and switch the box orientation to vertical when needed but it's simpler like this.

@pravi
Copy link

pravi commented Nov 1, 2023

I have added both patches, the account used I can now see, but the window is still same (cutting on both sides).

	- fix domain blocking button layout for linux phones
@eerielili
Copy link
Contributor Author

I have added both patches, the account used I can now see, but the window is still same (cutting on both sides).

Nice. I think I know why it's cutting, it must be the margin-end value that I doubled when trying to put the button on another line. I put it back to normal, I think it should be fixed for you.

@eerielili
Copy link
Contributor Author

@pravi i did not tag you, could you test 8cb26d5 ? thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow blocking entire domain
2 participants