-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow blocking entire domain from conversation details #1493
base: master
Are you sure you want to change the base?
Conversation
5d5e0ae
to
4790dfe
Compare
I have tested it on Purism Librem 5 (debs here https://people.debian.org/~praveen/mobian/), it is not adaptive, please use libadwaita widgets to make it adaptive. arrange the buttons vertically. |
When I have multiple accounts, it does not show which account I'm using. |
4790dfe
to
89bad90
Compare
I partly addressed it in #1482, I'll do a separate one with a line of text underneath the contact's avatar in conversation settings indicating which account is used.
I have force pushed a fix to my branch so that the button goes on a new line. Could have calculated the root window width, stored it, and switch the box orientation to vertical when needed but it's simpler like this. |
I have added both patches, the account used I can now see, but the window is still same (cutting on both sides). |
- fix domain blocking button layout for linux phones
89bad90
to
8cb26d5
Compare
Nice. I think I know why it's cutting, it must be the margin-end value that I doubled when trying to put the button on another line. I put it back to normal, I think it should be fixed for you. |
Might close #1429.
I tested it on my end, works well. Might look around for less lines of code, still a WIP.
When domain is blocked:
Don't hesitate to give me feedback.