A simple fix for I2P and Lokinet.

[PoneyClairDeLune]

A simple fix for I2P and Lokinet.

The job of maintaining TLDs for mixnet TLDs can become overwhelming, just saying. Better to just offer a togglable option to allow untrusted certificates.

[Quix0r]

Is there a way to request the domain's suffix e.g. domain.get_suffix() and check it if it is in an array/list of suffixes instead? This would simplify the code a bit. Then other proxified suffixes can be easily added to the array/list.

[PoneyClairDeLune]

Is there a way to request the domain's suffix e.g. domain.get_suffix() and check it if it is in an array/list of suffixes instead? This would simplify the code a bit. Then other proxified suffixes can be easily added to the array/list.

I know nothing about Vala, I just treated Vala as C when I was writing that code and was afraid of breaking anything. Maybe some others could get it into an array instead.

[XutaxKamay]

Would be great to add snode aswell if that's possible

[eerielili]

as @Quix0r pointed, you could do something like

string[] domain_exceptions = {".onion", ".i2p", ".loki", ".etc"}; 

foreach (string domain_exception in domain_exceptions) {
    if ( domain.has_suffix(domain_exception) && errors == TlsCertificateFlags.UNKNOWN_CA) {
      //do stuff
      return true;
    }
}

[PoneyClairDeLune]

I'll do that shortly.

[eerielili]

@PoneyClairDeLune Nice, and I wanted to add too that the domain_exceptions variable should have a more apt name like tld_exceptions, I think it's more readable

[PoneyClairDeLune]

@eerielili Done in e4da09f

PS: Not sure if I should have that string array placed outside of that validation function though... I know nothing about Vala.

[eerielili]

@PoneyClairDeLune Nice. Yeah, you should place inside the function, it looks cleaner and it'll work the same since they'll be in the same scope.
I'm not too big on OOP but I suggest declaring it as a private const string[] at the top of the class if needed in other functions, then you could call it with this.tld_exceptions.

[PoneyClairDeLune]

Would be great to add snode aswell if that's possible

@XutaxKamay What's an "snode"?

Edit: Is it something related to the "Snet" in Cuba?

[XutaxKamay]

Would be great to add snode aswell if that's possible

@XutaxKamay What's an "snode"?

Edit: Is it something related to the "Snet" in Cuba?

https://git.lokinet.io/lokinet/lokinet/src/branch/dev/docs/dns-overview.md