Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds mute to video iframe srcs to allow auto play #1112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adds mute to video iframe srcs to allow auto play #1112

wants to merge 1 commit into from

Conversation

atrzyna
Copy link

@atrzyna atrzyna commented Feb 28, 2019

The iframe src for both youtube and vimeo need to have mute added to allow auto play again. Issue #1111

@atrzyna
Adds mute to video iframe srcs to allow auto play
97d8a25 
The iframe src for both youtube and vimeo need to have mute added to allow auto play again. Issue dimsemenov#1111
epcgrs
epcgrs reviewed Jun 2, 2022
View reviewed changes
Copy link

@epcgrs epcgrs left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good, but I wonder if not better to make this dynamic?

wow, now that I've seen that it's been over 2 years of this issue, I don't know if the author is still looking at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epcgrs epcgrs epcgrs left review comments

@devShamim devShamim devShamim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atrzyna @devShamim @epcgrs