fix infinite updates on empty slug #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you man! You saved my day. This extension is useful but crashes the UI when I erase and modify the slug enough... EDIT: Didn't work :( |
|
Hi @LaakJoonas |
|
I figured it out. Your fix is good. My setup had another similar issue I fixed. |
|
Could you merge this pull request ? |
|
its alive? |
|
@albanallee @romanlex the PR is alive, alas the repository itself doesn't seems so, and I'm not able nor to merge it without the owner's approval nor publish on npm. I ended up with copy-pasting this code into my Directus projects (anyway I usually have a plenty of custom extensions). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #11