feat(test): add bundle size limit #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgurusinga
reviewed
May 7, 2024
|
Nice idea, but I don't think we should add it during the unit tests process, but in a separate test process, because this is not an unit test. We can create a new job during the Github action for it and have some measures:
|
Bumps [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action) from 0.19.0 to 0.20.0. - [Release notes](https://github.com/aquasecurity/trivy-action/releases) - [Commits](aquasecurity/trivy-action@d710430...b2933f5) --- updated-dependencies: - dependency-name: aquasecurity/trivy-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* refactor: add new placeholders variables * refactor: get route description from strapi translations
this is a collapsible html tag
* refactor: remove SubflowState * test: add unit tests for navItemsFromDoneStates() + stepStates()
This reverts commit 841c141.
This reverts commit facaaaa.
This reverts commit ad038d2.
|
what happens to the commit messages Chris? @chohner :O |
Apparently I rebased instead of merge 😢 I'll fix this PR soon, we have way too many |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: We sometimes bundle large dependencies or data chunks into our bundle. this adds a size limit for the bundle that is checked after unit tests: