Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements: modern methods, less panic-prone #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

michurin
Copy link

@michurin michurin commented Jan 6, 2024

Minor code update:

  • Using r.URL.Query().Get("...") instead of r.URL.Query()["..."] where this is the case
  • Using modern strings.Cut instead of strings.SplitN(..., 2)
  • Bumping required go version up to 1.18 to enable strings.Cut using
  • Fixing panic-prone code w.Header().Set(h[0], strings.TrimSpace(h[1])), where h can have arbitrary length
  • Dealing with ROUTES similarly to PORT: check len() of value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant