Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uncommented the required permission #412

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

cpanato
Copy link
Collaborator

@cpanato cpanato commented Feb 12, 2022

  • uncommented the required permission and made a copy of the file and added a -dev suffix

Fixes #397

/assign @timoreimann

Copy link
Collaborator

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small gotcha, otherwise good.

releases/v0.1.36-dev.yml Outdated Show resolved Hide resolved
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@timoreimann
Copy link
Collaborator

I have filed #415 to track updating our release pipeline to account for the new dev.yaml file.

@cpanato cpanato deleted the fix-crole branch February 21, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misconfigured cloud-controller-manager.yml (HA deployment that uses daemonset)
2 participants