Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framing - reset graph context after recursing through named graphs #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pjohnston-wiley
Copy link

When framing a JSON-LD document with at least one named graph, the current graph (state['graph']) was not being reset after recursing through the named graphs. Since the code iterates in alphabetical order, this only manifested for objects in the default graph that had @ids greater than the @id of the first named graph. This would be a good test to put into the overall JSON-LD framing test suite, please let me know if you want a formal example.

@davidlehn
Copy link
Member

Hi, If you have a chance could you provide a test example? I'll try to get it into main json-ld.org test suite to avoid the same issue in other implementations. If you want to add a patch to that repo, that works too. Thanks, and apologies for the late response.

@pjohnston-wiley
Copy link
Author

sure - i may already have one in some of the posts i put on the WG issues list, e.g. this. I'm traveling this week but i'll try and put something together soon.

@pjohnston-wiley
Copy link
Author

There now

@anatoly-scherbakov
Copy link
Contributor

Should this be merged since json-ld/json-ld.org#663 is merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants