Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bugs in embed and remote frame context handling. #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RDProjekt
Copy link

Hi!

We noticed two bugs in your code. One is in the framing algorithm when the remote frame contains a context url (the "if" was never True and if/else branches were reversed), and the other is in the _remove_embed function (lack of "enumerate" while iterating embed['parent']).

Here's a pull request with patches. We also added some unit-tests for the first bug. Because json-ld-org tests don't cover it, we had to come up with our own.

Best regards,
RD Projekt

Łukasz Jancewicz added 2 commits July 24, 2014 16:11
@dlongley
Copy link
Member

Thanks @RDProjekt! We need to take a closer look at this when we can, but it does look like we want to pull it in. We do need to get generic unit tests (that aren't just the official JSON-LD test suite) working and running in travis so we can throw more in there as needed and this could be a good start for that. We'd like, at least eventually, all of the tests (official JSON-LD test suite and our own custom ones) to run at the same time.

@davidlehn
Copy link
Member

It would be good to try and get these tests into the main test suite. We want to be able test all implementations for these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants