Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added URL to context resolution error message. #539

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

brianorwhatever
Copy link

No description provided.

Copy link
Member

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggestions. Thanks!

lib/ContextResolver.js Outdated Show resolved Hide resolved
lib/ContextResolver.js Outdated Show resolved Hide resolved
brianorwhatever and others added 2 commits October 2, 2023 15:17
Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
@davidlehn
Copy link
Member

  • It's unfortunate to duplicate like this, but perhaps helpful. In theory the details and cause should still be looked at to possibly find a lower level issue. I'm not sure how to cleanly indicate this.
  • Would it be better to put the URL at the end? Would make the common text easier to read before the potentially long variable content.
  • The node doc loader outputs something similar for regular invalid URLs. It doesn't handle garbage URLs very well and puts them directly in the error message without good sanitizing. I think that problem will happen before URLs get here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants