Fix "Invalid calling object" in Edge and ES6 syntax error in IE #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Wrap indirect `setImmediate` into function to prevent "Invalid calling object" error in IE/Edge (due to a bug it's an error to call `setImmediate` indirectly). * Fix `babel-loader` include condition to transpile `rdf-canonize` dependency.
AlexeyMz
force-pushed
the
fix-ie-support
branch
from
021d004
to
fa4c911
Compare
|
Hi @davidlehn @dlongley |
|
We encountered same issue and we end up importing from dist instead of primary entrypoint something like this: Unfortunately, we still experience |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included changes:
setImmediateinto function to prevent "Invalid calling object" error in IE/Edge (due to a bug it's an error to callsetImmediateindirectly).babel-loaderinclude condition to transpilerdf-canonizedependency.This PR fixes issue #319