Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the regex for bnodes when parsing n-quads. #158

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jimflip
Copy link

@Jimflip Jimflip commented Dec 6, 2016

Actually only a partial fix to support '_' in the bnode label as per specification:

http://www.w3.org/TR/n-quads/#BNodes

The characters _ and digits may appear anywhere in a blank node label.

This causes issues on rdflib also which is utilising jsonld.js for json-ld serialisation.

@Jimflip
Copy link
Author

Jimflip commented Dec 6, 2016

So the test doesn't build consistently before this PR.
So master is effectively broken?

@dlongley
Copy link
Member

dlongley commented Dec 6, 2016

@Jimflip,

So the test doesn't build consistently before this PR.
So master is effectively broken?

Some new framing tests were added recently due to some changes to the framing algorithm in the specification. We need to disable those for now so the tests pass again -- and then update our framing algorithm (when we have time) so they all pass. That's probably what you're seeing.

@harlantwood
Copy link

This is probably also what we're seeing in #156.

@Jimflip
Copy link
Author

Jimflip commented May 25, 2018

Just noticed this is still open, and no idea of how things have progressed since.

Shall I close this PR or have a crack at resolving conflicts?

@dlongley
Copy link
Member

@Jimflip,

The RDF parser has moved over to rdf-canonize (and really should move into its own separate module, but that's for another day). You'd need to file a PR there against this line it looks like:

https://github.com/digitalbazaar/rdf-canonize/blob/master/lib/NQuads.js#L17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants