New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check LF version do not decrease with upgrade #19168
base: main
Are you sure you want to change the base?
Conversation
d76b2be
to
d14b92d
Compare
sdk/daml-lf/validation/BUILD.bazel
Outdated
@@ -98,10 +123,16 @@ da_scala_test_suite( | |||
# TODO https://github.com/digital-asset/daml/issues/17254 | |||
# this test should not use canton and be part of the suite above | |||
[ | |||
da_scala_test( | |||
da_scala_test_suite( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We sleep the 6 test classes to avoid rerun all of them in case of one is flaky.
sdk/daml-lf/validation/BUILD.bazel
Outdated
@@ -98,10 +123,16 @@ da_scala_test_suite( | |||
# TODO https://github.com/digital-asset/daml/issues/17254 | |||
# this test should not use canton and be part of the suite above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this comment needs to be copied to the test suites you're splitting out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
d14b92d
to
a78534a
Compare
No description provided.