New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass project name and version from daml.yaml
to daml test
when not using --files
#18528
base: main
Are you sure you want to change the base?
Conversation
daml.yaml
to daml test when not using
--files`daml.yaml
to daml test
when not using --files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactor :D
This is a right pain to debug, as stack traces are thrown away in several places, but I've tracked it down to: |
@remyhaemmerle-da, I think you had requested this, do we still need it? |
The core of the change here is that we set
optMbPackage{Name,Version}
in thecliOptions
passed toexecTest
to the values fromdaml.yaml
, but only when runningdaml test
in "project" mode (i.e. when not using--files
). I also took the freedom to refactor this a bit, since I had a hard time following the logic as it was.Status: a bunch of tests are failing with errors like the one below, which points to the scenario service not expecting the package name to be present. I'm making this a draft PR until I have time to fix that.