Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation via Cmake #26

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add installation via Cmake #26

wants to merge 4 commits into from

Conversation

jhh
Copy link

@jhh jhh commented Jul 17, 2020

This makes it a bit simpler to include in projects using Cmake. I've tested installation and project builds on macOS and Ubuntu 18.04.

Copy link
Owner

@digint digint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for contributing!
(sorry for the long delay, i missed that one)

can we move this to contrib/cmake (or similar)

I'd hate to pollute this "tiny ;-) header-only" project with configs from all sort of build systems and IDE's (see #28 )


project("tinyfsm"
LANGUAGES CXX
VERSION 1.0.1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 1.0.1 ? should be 0.3.2
Can we extract this from include/tinyfsm.hpp line 26 ?
If not, do you know of some common / portable place to define the version number?
I'd hate to maintain the version in multiple files.

the "library" (API compatibility) version would be 0.3

cd build
cmake ..
sudo cmake --build . --target install
```
Copy link
Owner

@digint digint Mar 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake users should all know how this works, do you really think this is required? maybe add instructions in header of CMakeLists.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants