New timestamp_format "human" with separators to increase human readability #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derSeddy
force-pushed
the
add_timestamp_format_human
branch
from
786e90e
to
5413c56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first glance I'm having a hard time to read the dates the provided
timestamp_formatvalues generate, thus I added a newtimestamp_formatfor increased human readability.The new format is called
humanand it is likelongbut adds dashes as separators and replaces theTwith an underscore.Examples:
my_voulme.2023-11-23_19-53my_voulme.2023-11-24_04-40I added the format to the code and documentation and changed
btrbk_timestamp_matchto match the new format.What do you think about the new format? Would you accept it like I provided it, or would you suggest different separators?