pass device status to DeviceCard, add disconnected icon

[bohdanprog]

Closes #235

[ErikSin]

The device should update when it disconnects here. I have noticed with some playing around that it is working pretty inconsistently. Its registering the device as disconnected only sometimes.

@bohdanprog if you could make that change i was referring to about the boolean.

@EvanHahn can you look into the api.on('local-peers', onPeers); and see if you can find any problems in the backend

[EvanHahn]

@EvanHahn can you look into the api.on('local-peers', onPeers); and see if you can find any problems in the backend

tl;dr: I think useLocalPeers looks fine to me.

I only see two small issues in useLocalPeers, and I would only expect these bugs to manifest at the very beginning (if at all).

1. During the initial subscription, it's possible that a local-peers event will fire before api.listLocalPeers() resolves. Here's the code:

   comapeo-mobile/src/frontend/hooks/useLocalPeers.ts

   Lines 30 to 37 in c64cdf0

   	api.on('local-peers', onPeers);
   	api
   	.listLocalPeers()
   	.then(onPeers)
   	.catch(err => {
   	error = err;
   	listeners.forEach(listener => listener());
   	});

   Imagine that api.listLocalPeers() starts, then a local-peers event fires, then api.listLocalPeers() resolves. The data might be stale.

2. If api.listLocalPeers() fails after we're unsubscribed, it might fire listeners unnecessarily.

   Imagine that api.listLocalPeers() starts, then we unsubscribe. This would cause stale listeners to be called.

Again, not sure if these are real issues; I would need to test.

Also, I might have missed something!

[EvanHahn]

LGTM but we should wait for @ErikSin before merging, because it sounds like he was seeing some strange behavior.

[ErikSin]

@EvanHahn on testing, i did the followng: api.on('local-peers', peers => {console.log(peers )}).. And i was getting very inconsistent results when my device was leaving or joining a network. It was not the expected behaviour. so i think it is the backend? But lmk if you want to hop on a call and look at it together

[EvanHahn]

I'd love to hop on a call and look at this, as I can't see any obvious problems with the code.

[EvanHahn]

Looks like there's a merge conflict here. @bohdanprog Could you fix?

[EvanHahn]

If there's a bug here, it seems unlikely that it's in this PR. LGTM.

evan has approved