SV-COMP 24 fixes #176
Open
SV-COMP 24 fixes #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterschrammel
approved these changes
Nov 24, 2023
|
We should merge peterschrammel/cbmc#29 before this so that the submodule doesn't point to my dev branch |
|
done |
The warnings (errors due to -Werror) are coming from CBMC. The issue has been introduced in gcc 13 and is now fixed on CBMC develop branch in commit 3a6cef0 which can't be cleanly applied to the version that 2LS is currently using. With no current plans to migrate to C++-20, we can ignore the warning for now.
The API is different across the various template generators and the method is always called directly on the given template generator type, i.e. in a non-virtual way. Therefore, there is no need to implement this method as virtual.
FrNecas
force-pushed
the
fnecas-svcomp-24
branch
from
accd9ab
to
651828d
Compare
|
I've noticed that our clang-format config for breaking after bracket wasn't consistent with the code style, hence the linting errors. Hopefully should be passing now. |
viktormalik
approved these changes
Nov 27, 2023
| @@ -22,6 +22,8 @@ Author: Peter Schrammel | |||
|
|
|||
| #include "2ls_parse_options.h" | |||
|
|
|||
| #define NOT_MATH_FUN(call, fun) call != fun &&call != fun "f" && call != fun "l" | |||
There was a problem hiding this comment.
Missing space, is that enforced by clang-format?
Suggested change
| #define NOT_MATH_FUN(call, fun) call != fun &&call != fun "f" && call != fun "l" | |
| #define NOT_MATH_FUN(call, fun) call != fun && call != fun "f" && call != fun "l" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces various small fixes required for SV-COMP 2024: