Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge example logic in one single file #152 #178

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ivofernandes
Copy link

As we talked on this issue

#152

The objective of this pull request is that the pub.dev can show in the website the complete example of how to use this package, the single file example may look harder to read in an IDE but easier on the example page.

https://pub.dev/packages/percent_indicator/example

Hope it helps :)

@ivofernandes ivofernandes mentioned this pull request Sep 24, 2022
@diegoveloper
Copy link
Owner

Hey, thanks for the contribution, I have a better idea, what about keeping the files as it's(because people will find easier the code when they search on the repo) but update the main file.

On the main file we could have, two examples for Circular and two for Linear, and a new button at the bottom of the screen (fixed, not scrollable, the content is scrollable), with the text "More Samples" , and that button will redirect to the current "menu" we have on the main screen.

What do you think ?

@ivofernandes
Copy link
Author

Well, the package is yours so you are the one that needs to decide that trade-off :)

On my packages I put all on the example in the main.dart file, because I know that most developers will just see the code on the example webpage and will not even bother to go to github. Maybe in the future the pub.dev example page will have a file navigation, but for now, they just present the main.dart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants