Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style guide #581

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

Style guide #581

wants to merge 16 commits into from

Conversation

briandowns
Copy link
Contributor

@briandowns briandowns commented Dec 22, 2022

Well detailed description of the change :

Initial attempt at drafting a style guide. Open to any and all suggestions.

Resolves: #

#532

Type of change:

  • Bug fix

  • New feature

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Housekeeping

  • Tests have been updated to reflect the changes done within this PR (if applicable).

  • Documentation has been updated to reflect the changes done within this PR (if applicable).

Preview (Screenshots) :

Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
@briandowns briandowns marked this pull request as ready for review December 22, 2022 22:01
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
@Jason2605
Copy link
Member

A very cool project that could come off the back of this is a linter, not sure if you're still in your work hackweek or if that's long gone but potentially one for that!

@briandowns
Copy link
Contributor Author

I was thinking the same thing! I'll add that to the list of things for hackweek. It's the last week of January. Shopping it around this week to get some contributors.

@Jason2605
Copy link
Member

I was thinking the same thing! I'll add that to the list of things for hackweek. It's the last week of January. Shopping it around this week to get some contributors.

Ah perfect! Sounds really good! You could do it in Dictu, or even potentially in JS (TypeScript) and we could potentially merge it into the VSc plugin, just thinking out loud here

Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
@briandowns
Copy link
Contributor Author

I was thinking the same thing! I'll add that to the list of things for hackweek. It's the last week of January. Shopping it around this week to get some contributors.

Ah perfect! Sounds really good! You could do it in Dictu, or even potentially in JS (TypeScript) and we could potentially merge it into the VSc plugin, just thinking out loud here

Created #593 to capture this bit of the convo.

Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
@briandowns
Copy link
Contributor Author

I'm happy to make changes on any of this based on how you (@Jason2605) want Dictu to be written. This was just some stuff I came up with based on how I found myself writing it.

@Jason2605
Copy link
Member

It's all good mate I'd agree with everything we have so far! Potentially may be quite a long living PR (sorry) until we add everything we want to be added to it

@briandowns
Copy link
Contributor Author

Cool cool. Down for it to live forever if need be. 😀

@Jason2605
Copy link
Member

Cool cool. Down for it to live forever if need be. 😀

I'll try not make it be forever haha, but cheers man

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants