Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of merge-partitions #1802

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix usage of merge-partitions #1802

wants to merge 2 commits into from

Conversation

souravsingh
Copy link
Contributor

@souravsingh souravsingh commented Oct 21, 2017

  • Is it mergeable?
  • make test Did it pass the tests?
  • make clean diff-cover If it introduces new functionality in
    scripts/ is it tested?
  • make format diff_pylint_report cppcheck doc pydocstyle Is it well
    formatted?
  • Did it change the command-line interface? Only backwards-compatible
    additions are allowed without a major version increment. Changing file
    formats also requires a major version number increment.
  • For substantial changes or changes to the command-line interface, is it
    documented in CHANGELOG.md? See keepachangelog
    for more details.
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Do the changes respect streaming IO? (Are they
    tested for streaming IO?)

Related to #1582

@codecov-io
Copy link

Codecov Report

Merging #1802 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1802   +/-   ##
======================================
  Coverage    0.05%   0.05%           
======================================
  Files          78      78           
  Lines        9749    9748    -1     
  Branches     2456    2455    -1     
======================================
  Hits            5       5           
+ Misses       9744    9743    -1
Impacted Files Coverage Δ
scripts/merge-partitions.py 0% <ø> (ø) ⬆️
src/oxli/hashgraph.cc 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d0f068...bdd25b1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants