[Bugfix & Enchancement?] Clicking on the sound slider plays the sound at wrong volume #7065
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qndel
reviewed
Apr 10, 2024
|
|
||
| // Do not play a duplicate sound if we are clicking on the sound slider. | ||
| // CurrentMenuId == 5 is the options menu, i == 1 is the sound slider. | ||
| if ((sgCurrentMenuIdx != 5) || (i != 1)) { |
There was a problem hiding this comment.
Suggested change
| if ((sgCurrentMenuIdx != 5) || (i != 1)) { | |
| if (!(sgCurrentMenuIdx == 5 && i == 1)) { |
There was a problem hiding this comment.
I could also be ok with, but I can see how Qndel's suggestion makes logical sens
Suggested change
| if ((sgCurrentMenuIdx != 5) || (i != 1)) { | |
| if (sgCurrentMenuIdx != 5 || i != 1) { |
|
Why remove range from the volume? I can still hear sound till 4 notches from the bottom. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does two things: the first commit is a bug-fix, the second one is a related adjustment.
The sound slider in the game menu plays the move sound at the previous volume level when clicked on, as clicking itself will play the same sound (
gmenu.cpp) and because of that the duplicate ingamemenu.cpp/gmenu_left_mousewill never play again. This fix makes the left click not play a sound when clicked on the sound slider as an exception. If there's a better way to do it, let me know!The second one changes the minimum volume from -100.0 dB to -60.0 dB. Initially I thought the sound slider was wrong, as moving it to the middle almost made the music go silent, but after checking the code, it seems to be working perfectly, logarithmic conversion et al, just the minimum value seems to be way too low and this caused the slider to seem off. -60.0 dB is arbitrary, but in my opinion, -100.0 dB seems too low in any case.