Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pl.po #6897

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update pl.po #6897

wants to merge 1 commit into from

Conversation

WMag98
Copy link

@WMag98 WMag98 commented Jan 12, 2024

Here is Wojtek from the WiA Parker group. We are the authors of the Polish localization used in DevilutionX. The corrections we have included are a matter of quality that we wanted to include in our localization. Someone made a mistake here in a few places without taking into account why we translated certain things this way. There may be more such misunderstandings of the context. Due to our time, we only edited those that are visible at first glance.

@AJenbo AJenbo requested a review from qndel January 12, 2024 17:50
@qndel
Copy link
Member

qndel commented Jan 13, 2024

Eh, other than the typo fix and 2 new translations, I don't really like these changes 🤷 old translations were fine

@@ -401,14 +401,14 @@ msgstr ""

#: Source/DiabloUI/hero/selhero.cpp:282 Source/DiabloUI/hero/selhero.cpp:285
msgid "Enter Name"
msgstr "Wpisz Imię"
msgstr "Wpisz Nazwę"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Nazwa" seems to not be the best choice here, we're talking about a name for a character, hence "imię" seems better as it relates to a character, to a person somewhat.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We agree with you.


#: Source/DiabloUI/hero/selhero.cpp:314
msgid ""
"Invalid name. A name cannot contain spaces, reserved characters, or reserved "
"words.\n"
msgstr ""
"Niepoprawne imię. Nazwa nie może zawierać spacji, znaków specjalnych i "
"Niepoprawna nazwa. Nie może ona zawierać spacji, znaków specjalnych i "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto about "nazwa" vs. "imię" when related to a character.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We agree with you.

@@ -4631,7 +4631,7 @@ msgstr "menu"

#: Source/panels/mainpanel.cpp:91
msgid "inv"
msgstr "ekwipunek"
msgstr "inw"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why "inw", where it comes from? "Inwentarz"? If yes then it is inconsistent -- in other places in this file "inventory" is translated to "ekwipunek", using a shortened different word just in this context looks strange.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe shortened form/abbreviation is needed to fit on the button and look decent.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"ekwipunek" does fit, doesn't look the best, but readable:

20240117195412_1

"inw" would look strange to be honest.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right I said fit and look decent. The overlapping letters looks pretty bad, in my opinion. No idea what word and/or abbreviation would make more sense for the language though.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English version uses "Inv" instead of "Inventory". For the same reason Polish version should use "Ekw" (or maybe "Ekwip"?) instead of "Ekwipunek". Honestly I hate how Ekwipunek button looks, letters are super tight

Copy link
Member

@AJenbo AJenbo Jan 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the same reason

I don't think Polish necessarily has the same linguistic rules as English.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zasoby, Zapasy, Skarby

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the same reason

I don't think Polish necessarily has the game linguistic rules as English.

They shortened english Inventory into Inv so I don't see a reason not to shorten polish Ekwipunek. It has nothing to do with linguistic rules. Just saying shortening is not a crime if the made it in official release... Also I am Polish if that matters.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the same reason

I don't think Polish necessarily has the game linguistic rules as English.

They shortened english Inventory into Inv so I don't see a reason not to shorten polish Ekwipunek. It has nothing to do with linguistic rules. Just saying shortening is not a crime if the made it in official release...

Inventory -> inv -- makes sense, Ekwipunek -> inw -- what? If anything "Ekw" or "Ekwip", but both look a bit strange, I'm just saying there's no good short version for "Ekwipunek".

Also I am Polish if that matters.

Yeah, I know the pain man, same here ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants