Bugfix: Corruption item power #6665
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failing appears to be related to Discord |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corruption behaves very strangely, and can result in the player still having mana values greater than 0, and the player is still able to cast spells. This PR fixes that by visually setting mana and max mana to 0 without modifying the actual values. In addition, spells will fail to cast if this item power is active (Fails mana check), and Mana Shields will be forcefully removed. As a failsafe, there is a check to make sure there is no Mana Shield damage reduction if this item power is active.
On a side note, this item power appears to have very inconsistent behavior when it comes to restoration of mana. There are sources that normally restore mana that will no longer (Reading books, leveling up, using potions), and sources that still restore mana (Cryptic shrine, and some other shrines). I've decided to leave these alone in this PR, since I wasn't sure if unifying the behavior was in the scope of this, and whether or not the solution would be to prevent restoration of mana from ANY source, or to allow it from EVERY source, while visually the player sees 0/0 mana