WIP:Bring back likes on comments #7918
Conversation
Flaburgan
force-pushed
the
2999-likes-comment
branch
from
20e3494
to
5dd9d69
Compare
Flaburgan
force-pushed
the
2999-likes-comment
branch
2 times, most recently
from
bd0df93
to
e60cfd5
Compare
| }, | ||
|
|
||
| toggleLike: function(evt) { | ||
| if(evt) { evt.preventDefault(); } |
There was a problem hiding this comment.
Expected space(s) after "if".
app/services/comment_service.rb
Outdated
| @@ -10,6 +10,11 @@ def create(post_id, text) | |||
| user.comment!(post, text) | |||
| end | |||
|
|
|||
| def find!(comment_id) | |||
| #TODO check that the user has access to that comment first | |||
There was a problem hiding this comment.
- Layout/LeadingCommentSpace: Missing space after
#. - Style/CommentAnnotation: Annotation keywords like
TODOshould be all upper case, followed by a colon, and a space, then a note describing the problem.
Flaburgan
force-pushed
the
2999-likes-comment
branch
from
e60cfd5
to
06459cd
Compare
| urlRoot: "/comments", | ||
|
|
||
| initialize: function() { | ||
| this.likeInteractions = new app.models.Post.LikeInteractions(_.extend({comment: this}, this.get("likeInteractions"))); |
There was a problem hiding this comment.
Line 7 exceeds the maximum line length of 120.
| @@ -1,19 +1,15 @@ | |||
| // @license magnet:?xt=urn:btih:0b31508aeb0634b347b8270c7bee4d411b5d4109&dn=agpl-3.0.txt AGPL-v3-or-Later | |||
|
|
|||
| //require ../post | |||
| //require like-interactions | |||
There was a problem hiding this comment.
Expected space or tab after '//' in comment.
| @@ -0,0 +1,53 @@ | |||
| // This class contains code extracted from interactions.js to factorize likes management between posts and comments | |||
| app.models.Post.LikeInteractions = Backbone.Model.extend({ | |||
| initialize : function(options){ | |||
There was a problem hiding this comment.
- Extra space after key 'initialize'.
- Missing space before opening brace.
| this.likes = new app.collections.Likes(this.get("likes"), options); | ||
| }, | ||
|
|
||
| likesCount : function(){ |
There was a problem hiding this comment.
- Extra space after key 'likesCount'.
- Missing space before opening brace.
| return this.get("likes_count"); | ||
| }, | ||
|
|
||
| userLike : function(){ |
There was a problem hiding this comment.
- Extra space after key 'userLike'.
- Missing space before opening brace.
| success: function() { | ||
| self.post.set({participation: false}); | ||
| self.trigger('change'); | ||
| self.set({"likes_count" : self.get("likes_count") - 1}); |
There was a problem hiding this comment.
Extra space after key 'likes_count'.
| @@ -6,10 +6,15 @@ app.views.Comment = app.views.Content.extend({ | |||
| className : "comment media", | |||
| tooltipSelector: "time", | |||
|
|
|||
| subviews : { | |||
There was a problem hiding this comment.
Extra space after key 'subviews'.
| this.model.toggleLike(); | ||
| }, | ||
|
|
||
| likesInfoView : function(){ |
There was a problem hiding this comment.
- Extra space after key 'likesInfoView'.
- Missing space before opening brace.
| }, | ||
|
|
||
| likesInfoView : function(){ | ||
| return new app.views.LikesInfo({model : this.model}); |
There was a problem hiding this comment.
Extra space after key 'model'.
|
|
||
| likesInfoView : function(){ | ||
| return new app.views.LikesInfo({model : this.model}); | ||
| }, |
There was a problem hiding this comment.
Unexpected trailing comma.
Flaburgan
force-pushed
the
2999-likes-comment
branch
from
98d2e13
to
3b3b40b
Compare
| @@ -0,0 +1,53 @@ | |||
| // This class contains code extracted from interactions.js to factorize likes management between posts and comments | |||
| app.models.Post.LikeInteractions = Backbone.Model.extend({ | |||
| initialize : function(options){ | |||
There was a problem hiding this comment.
- Extra space after key 'initialize'.
- Missing space before opening brace.
| this.likes = new app.collections.Likes(this.get("likes"), options); | ||
| }, | ||
|
|
||
| likesCount : function(){ |
There was a problem hiding this comment.
- Extra space after key 'likesCount'.
- Missing space before opening brace.
| return this.get("likes_count"); | ||
| }, | ||
|
|
||
| userLike : function(){ |
There was a problem hiding this comment.
- Extra space after key 'userLike'.
- Missing space before opening brace.
| }, | ||
|
|
||
| userLike : function(){ | ||
| return this.likes.select(function(like){ |
There was a problem hiding this comment.
Missing space before opening brace.
| })[0]; | ||
| }, | ||
|
|
||
| toggleLike : function() { |
There was a problem hiding this comment.
Extra space after key 'toggleLike'.
| } | ||
| }, | ||
|
|
||
| like : function() { |
There was a problem hiding this comment.
Extra space after key 'like'.
| success: function() { | ||
| self.post.set({participation: true}); | ||
| self.trigger("change"); | ||
| self.set({"likes_count" : self.get("likes_count") + 1}); |
There was a problem hiding this comment.
Extra space after key 'likes_count'.
| }); | ||
| }, | ||
|
|
||
| unlike : function() { |
There was a problem hiding this comment.
Extra space after key 'unlike'.
| this.userLike().destroy({ | ||
| success: function() { | ||
| self.post.set({participation: false}); | ||
| self.trigger('change'); |
There was a problem hiding this comment.
Strings must use doublequote.
| success: function() { | ||
| self.post.set({participation: false}); | ||
| self.trigger('change'); | ||
| self.set({"likes_count" : self.get("likes_count") - 1}); |
There was a problem hiding this comment.
Extra space after key 'likes_count'.
Flaburgan
force-pushed
the
2999-likes-comment
branch
from
3b3b40b
to
afd070b
Compare
| initialize : function(options){ | ||
| app.models.Post.LikeInteractions.prototype.initialize({post : this.post}); // I don't know how to call the super method yet |
There was a problem hiding this comment.
- Line 7 exceeds the maximum line length of 120.
- Extra space after key 'post'.
Flaburgan
force-pushed
the
2999-likes-comment
branch
from
afd070b
to
88e142f
Compare
Flaburgan
force-pushed
the
2999-likes-comment
branch
from
88e142f
to
3cd67ef
Compare
| initialize : function(options){ | ||
| app.models.Post.Interactions = app.models.Post.LikeInteractions.extend({ | ||
| initialize: function(options) { | ||
| app.models.Post.LikeInteractions.prototype.initialize({post: this.post}); // I don't know how to call the super method yet |
There was a problem hiding this comment.
Line 7 exceeds the maximum line length of 120.
This comment has been minimized.
This comment has been minimized.
|
Hi @LorenzoAncora and thank you for taking time to share you thoughts about diaspora*. These worries about users using only likes instead of writing actual content are something often brought since I started working on reviving likes on comment. Despite this risk exists, I don't think this is going to happen. Likes mainly mean "I agree". It is a way to give importance to a comment. This can be achieve by posting another comment saying exactly that, but this doesn't work well at the moment because diaspora* doesn't have (yet?) threaded comments. That means if someone comments saying something you agree, but you arrive 1 hour after the comment has been written and 20 others comments have been posted since then, possibly driving the discussion in another direction, then writing another comment at the very bottom saying "I agree with comment 1" is not nice. So many users block themselves and don't do that. So instead of removing interaction because of less complete like instead of detailed comment, I think likes on comment will bring more interactions than before, make diaspora* a more alive place. So we're going to add likes on comment. If we do see some "bad" behaviors coming from that, we could remove the feature again. Future will tell us. And btw, if you really don't want to see likes on comment, just remove that commit from your pod. That's the power of free software ;) |
This comment has been minimized.
This comment has been minimized.
|
This is a pull request, and as such, is a place to discuss nuances about the technical side of the code submitted here. This is not the place to have philosophical discussions, and this is not the place to question the opinion of a majority of users. If anything, this place would be here. |
This comment has been minimized.
This comment has been minimized.
|
@Flaburgan @denschub Any Progress here? |
|
@tclaus unfortunately I switched my main focus of contribution to another project. I don't think I will continue to work on this. Feel free to follow up if you want to. |
Is there anything left over I can help with? |
|
My current work is pushed here. Honestly I don't remember exactly where I stopped, it was 2 years ago... |
|
I don't think I'm blocking this PR, but just in case
is a direct request to me: I really have no opinion here. This feature is one of those things that I don't like (pun intended), and if it would be completely up to me, we'd have no "likes" at all, not even for posts. Luckily, it's not up to me, and since people really want this, I'll not get in anyone's way. |
|
See the like? 😉 |
|
Obsoleted by #8203 |
I started to work on that task. @denschub asked me how I was seeing the UI. Quite frankly, I thought about going with the exact same design than the like for posts in the stream. So, I move the timestamp of comment from the bottom of the comment to the top on the right of the author in #7905 and display a "like" link at the bottom of the comment. The avatar of the other likers will go there too, like for posts. This UI works well for the users at the moment so I didn't see need for changes, at least for now. This fits OK in the SPV too. I wanted to open this PR to have feedback about that before going too far, so please share your opinion 😄