New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP:Add a welcome email #7823
base: develop
Are you sure you want to change the base?
WIP:Add a welcome email #7823
Conversation
I guess in light of the recent PGP bugs, more of our target audience switched to plain text only mails, so I think we should take care to provide a variant there :) |
I thought about that, but this email is sent right when the user register so he didn't set any email preferences. How one does set that btw? |
The preference is within the mail client. We send a MIME multipart message with two parts, one being HTML one being plain text. As for the Rails side it should be just adding the plaintext template and adding it to the render call iirc. |
Oh okay, I'll do it then. Should be done this afternoon. |
Thanks for the ping. I'll look this over in the next day or two. |
OK, I've had a look at the text. I think we should mention diaspora* in the email subject. I've also worked on the grammar and tried to make the message as clear as possible while remaining friendly and welcoming. I've also added a link to the tutorials and explained how to find the in-app help.
You'd then need to line 9 of app/views/registrations/welcome_email.haml to:
(I think that's correct syntax, but do check it.) I welcome comments on what I've done. |
I set the milestone to the next major for this PR, because I think this new welcome mail isn't really compatible with the already existing optional welcome message. When we now add a non-optional additional welcome mail, users on pods where the optional message is enabled would receive two mails (one notification mail for the PM, and the new welcome mail), and I think that's too much (at least I as a user would be already annoyed when I would receive two different welcome messages). There are multiple possibilities to solve this:
Point 3 would allow some more options to replace the old welcome message better:
What do others think? |
Hmm, that's a good point. Given that the current default of the optional welcome message is so bare, could we replace it with this new one? That would mean that new users would get the new, better welcome message as a PM, and get just one email notification if email has been enabled (and if they have registered a valid email address). I don't know if a more complex message with links in it as I've suggested is compatible with the yml file. My suggestions would be:
This would combine your options 2 and 3: we add a note to the changelog so that any podmins who have set an optional message have a chance to alter it to fit better with the new welcome message in this PR. However, no podmin would need to alter the |
Fla wants to send this as Mail and not as PM, so users have a mail containing their username and pod URL for the case they forget this. A PM wouldn't work then, so I would only send the PM if email is disable on the pod.
Yes, that's more or less what I was thinking about. That way we can include the advantage of the old message (customizable by the podmin) with the new, translatable and better mail. And we can safely remove the old PM, so people don't receive two messages. |
Looks like we have a consensus ;) |
After a discussion on discourse, it looks like this e-mail message is also a good place to verify the ownership of the e-mail address. So it should include a verification link, and we should not fill the user object's "email" property but the "unconfirmed_email" property when someone is registering. That means a new user will not receive any email from diaspora* (except the welcome one) as long as he didn't verified it (so no usurpation and no hardbounce). |
No, you need to set an email, because it is |
Oh, we have a I know users who put a wrong email on purpose when signing in because they want to remain anonymous, the email field could become optional imo. And that means |
Perhaps (getting very out of scope for this PR) if a user enters a non-existent email address, we could do the following: The first time a mail notification is sent, and bounces back with an 'address not known' error, send the user a PM (but not an email confirmation, of course) to inform them that the email address was not recognised, and give them three options:
As I said, not for this PR but a possible idea for the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Let's make eMail address validation part of this, so that the welcome mail also includes the validation link (Devise supports that!)
- Needs a plain text version
- We should also remove the welcome private message feature then, there is no need to send two mails.
- Some language feedback was provided.
This should still be an option for those who want to use that. |
No, as @denschub already said, there shouldn't be sent two mails after signup, and there is also no need to do so, the one should be good enough to cover everything. |
What about choosing one over another? |
The welcome mail will be sent when someone signs up, before they've had chance to set preferences. The decision to send one email automatically is a good one, in my opinion. I notice that I previously added mentions of the tutorials and in-app help to Fla's email text; as these features will be merged into the new guides, that text (and the link) will need to be updated. |
I know that. I misstated. What I was saying is that the podmin should be able to decide (in diaspora.yml) which version he or she wants to use. I personally like the direct message, that way they can easily respond to me with questions (which has happened on a few occasions). |
Since it's going to be used as email validation, private message won't work for that, so it needs to be email. And we still shouldn't spam the users with two mails.
As said, the new welcome email should cover all things needed to replace the old message, and for example to be able to answer we can just set the |
Typo in the current text: "Once logged" should be "Once logged in" |
To simplify the changes on the codebase and for the podmin, I was wondering about another option, could we keep the welcome PM by the podmin, but simply disable the e-mail notification for that specific PM? That way, we don't have to change anything for the podmin, and the users don't receive two e-mails. |
3aa1836
to
44c5300
Compare
Fixed, thanks. I also fixed @jhass remarks about Log in -> Sign in. |
How would you implement that? |
I don't like that there are two different messages, even if the podmin PM wouldn't also send an email notification. Can't we just combine both of them to just one single email/message, so the podmin message is also included there and we could set the podmin contact mail-address as |
So as discussed on discourse, this pull request adds a welcome email sent to the users once they filled the first form (with email and username). I only put the very basics in it, here is how it looks:
Subject is "Welcome aboard!"
Body:
@goobertron I'd love some feedback on the content, and what we could write.
I also still need to add links to the tutorials and help section text.
I guess I also need to write some tests...