Add app notifications #7725
Add app notifications #7725
Conversation
| = t(".receive_app_notifications") | ||
| = form_for "user", url: edit_user_path, html: {method: :put} do |f| | ||
| = f.fields_for :email_preferences do |type| | ||
| #email_prefs |
There was a problem hiding this comment.
- Do not repeat id "#email_prefs" on the page
idattribute must be in lisp-case
|
Thanks for working on that, @Radicalchaos! Being able to turn off notifications completely for different kinds of events would be super cool. Please be aware that our current system for storing preferences is... not the nicest, and it may not even be easily possible to add preferences for notification types, as our current email notifications are currently implemented via the (linking this PR to the matching feature request, which is #7686) |
|
Hey @Radicalchaos! Do you plan on continuing this work? Is there anything we can do to assist you here? |
|
After a team-internal discussion, let's go ahead and close this PR. There is a lot of work left to do, especially since this PR is a front-end only PR for now. The backend portion is the more complicated stuff, and the frontend has to be adjusted either way, so closing this won't get rid of much. If someone is interested in working on this, feel free to pick up this PR and base your own work on the work being done here. We will eventually work on this feature, because we agree that this is important and we really want to have it ourselves. :) |
This PR will add a symmetrical set of options for in-app notifications, as is currently available for email.