Explicit erosion #2665
Open
Explicit erosion #2665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work in progress, re-implement the erosion based on a simple kernel search rather than the distance array, since the data are sparse and this allows a far smaller number of calculations to be performed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2665 +/- ##
==========================================
+ Coverage 78.40% 78.46% +0.05%
==========================================
Files 613 613
Lines 75349 75958 +609
Branches 10761 10924 +163
==========================================
+ Hits 59081 59604 +523
- Misses 14087 14163 +76
- Partials 2181 2191 +10 |
|
On main: This branch: Comparison of output: => I believe this gives the same output and is clearer to read. The ~ 15s reduction in wall clock is a nice to have which will be data set dependent. I note in passing that this approach will be more GPU friendly also. |
Add new comments to explain what is going on, leave the new code as a reference implemntation but do not link it as I am not convinced that the performance is better on all architectures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
dials.find_spotsuse explicit erosion based on a simpler kernel search rather than the distance-based method as currently implemented, for a small performance improvement and also for simpler understanding for future code archeologists