write the diff to disk

[dermen]

always leaves a debug trail

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.34%. Comparing base (5dd0b6c) to head (6ebbaa9).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2612      +/-   ##
==========================================
- Coverage   78.34%   78.34%   -0.01%     
==========================================
  Files         611      611              
  Lines       75386    75393       +7     
  Branches    10767    10767              
==========================================
+ Hits        59062    59066       +4     
- Misses      14143    14145       +2     
- Partials     2181     2182       +1     

[dermen]

@phyy-nx , any chance we might merge this in to master ?

[phyy-nx]

Hi, the phil params are shown in the log file for dials.stills_process, named dials.process.log. That happens here. Is this sufficient for the phil params?

The other bits you've added are os.cwd and the command line arguments. I'd argue os.cwd isn't that relevant because output.output_dir is more important, which is in the diff phil. The command line arguments are folded up into the diff phil as well, except for the image file arguments (in the variable all_paths). Those I could see printing out using logger.info either right before or right after the diff_phil is shown. Probably useful to do that.

Thoughts? My opinions aren't super strong here :)