Add check for compatible cells in cosym output #2526
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2234
A suggestion that I welcome discussion on.
Should we explicity check and raise a RuntimeError when the cosym procedure has incorrectly reindexed the unit cells to be incompatible with each other?
Avoids silent continuation when there is an issue, but may make some datasets unprocessable 🤔
Maybe this can be merged in when we think we have addresed #2486
Bonus points as this makes one of our cosym command line tests fail due to incompatible cells.