Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove as_grid_scan from dials.import #2454

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

graeme-winter
Copy link
Contributor

Is not useful, and is misleading as it makes data into stills rather than image sequence. If we want to reinstate it, this can be reverted and fixed up appropriately.

Fixes #2452

Mentined in #2447

graeme-winter and others added 3 commits July 5, 2023 14:49
Is not useful, and is misleading as it makes data into stills rather than
image sequence. If we want to reinstate it, this can be reverted and fixed
up appropriately.

Fixes #2452

Mentined in #2447
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #2454 (8b3c9c9) into main (da59c1d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 8b3c9c9 differs from pull request most recent head 19a763c. Consider uploading reports for the commit 19a763c to get more accurate results

@@            Coverage Diff             @@
##             main    #2454      +/-   ##
==========================================
- Coverage   78.74%   78.73%   -0.01%     
==========================================
  Files         606      606              
  Lines       74096    74087       -9     
  Branches    10073    10070       -3     
==========================================
- Hits        58347    58336      -11     
+ Misses      13617    13615       -2     
- Partials     2132     2136       +4     

@ndevenish
Copy link
Member

Given the problem last time we removed one of these, I'd be more comfortable deprecating it first?

@graeme-winter
Copy link
Contributor Author

I take your point with this. It does not change the fact that it doesn't work and is misleading and useless, but deprecating for next release then removing after release does seem sane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove as_grid_scan from dials.import
3 participants