-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clustering index descending from 0 #2318
base: main
Are you sure you want to change the base?
Conversation
I hoped I'll be able to solve the issue myself, but I am at loss. I have prepared this branch to reverse the clustering order, so that the largest cluster is indexed 0, second largest is indexed 1 and so on. This code failed 3 tests: 2 of them relied on old naming scheme, and this was easy to fix. Unfortunately, this PR also causes @ndevenish, do you maybe happen to have an idea why saving combined files with different names influences refl indexing? |
Following #2311 and discussion therein, this PR suggests indexing clusters created by
dials.combine_experiments
from largest to smallest as well as indexing from 0 instead of an arbitrary integer, which depends on other phil parameters. Additionally, I took the liberty to rewrite the_save_output
method and nestedsave_in_batches
function, as the previous implementation of the latter was fairly difficult to read.This PR requires #2311 to be merged before it to avoid undefined variable error. Afterwards, I also need to perform a test or two to check whether everything behaves as expected.