Cleanup from Cakes LayeredPortrait PR #2198
Draft
+131
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- lot's of static typing and whitespace improvements - small adjustments to existing scripts
Pheubel
reviewed
Apr 26, 2024
| %RealPreviewPivot.add_child(current_previewed_scene) | ||
|
|
||
| if current_previewed_scene != null: | ||
| if not current_previewed_scene == null: |
There was a problem hiding this comment.
This could be turned into if current_previewed_scene: and it should still function the same. If it is done this way to make it more clear, i find that the earlier version reads better in intention.
| if current_portrait_data.get('ignore_char_scale', false): | ||
| scale = current_portrait_data.get('scale', 1) | ||
|
|
||
| var offset: Vector2 = current_portrait_data.get('offset', Vector2()) + current_resource.offset | ||
|
|
||
| if is_instance_valid(scene.get_script()) and scene.script.is_tool(): |
There was a problem hiding this comment.
scene.get_script() should probably be held in a variable and used later. direct access to Object.script is not intended, see Object's description.
Note: The script is not exposed like most properties. To set or get an object's Script in code, use set_script and get_script, respectively.
| if is_instance_valid(scene.get_script()) and scene.script.is_tool() and scene.has_method('_get_covered_rect'): | ||
| var rect: Rect2= scene._get_covered_rect() | ||
|
|
||
| if not scene.get_script() == null and scene.script.is_tool() and scene.has_method('_get_covered_rect'): |
There was a problem hiding this comment.
see feedback above, the variable containing the script reference could most likely be used here as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All credit goes to @CakeVR !
I just did this to make reviewing the core parts of the PR easier.