Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update libvips to 8.15.2 #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update libvips to 8.15.2 #49

wants to merge 1 commit into from

Conversation

littleforest
Copy link
Collaborator

No description provided.

mike-burns
mike-burns approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@mike-burns mike-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@mike-burns
Copy link
Collaborator

The issue is that the tarball contains bin, lib, and include, but libarchive-dev installs into /usr/lib/x86_64-linux-gnu/libarchive.so.

Without deploying you can confirm that the result of build.sh is correct by making sure libarchive.so is in the tarball:

tar -ztf build/heroku-22.tar.gz | grep libarchive

@mike-burns
Copy link
Collaborator

I've forked to https://github.com/thoughtbot/heroku-buildpack-vips BTW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-burns mike-burns mike-burns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@littleforest @mike-burns