New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jewish calendar new #18
base: master
Are you sure you want to change the base?
Conversation
Add option of the conversion to/from Jewish calendar dates into other calendardates
# Conflicts: # src/index.ts # test/conversions.ts
export class JewishCalendarDate extends JDNConvertibleCalendar {
public readonly calendarName = JDNConvertibleCalendar.jewish;
// Determine the number of months of a certain Jewish year
public readonly monthsInYear = 13;
|
// get remaining months to shift: max. this.monthsInYear - 1
const monthsToShift = Math.abs(months) % this.monthsInYear; The following cases have to be handled correctly:
|
@tobiasschweizer any updates for this PR? |
No, unfortunately not. Sadly, I don't have any time to work on this PR. Could you help in some way? Even just figuring out the algorithm for the months would be a big help. |
@emargareten Would you have any resources to help figure out the algorithm for dealing with the months? |
Number of possible months in a year has to be adjusted in order to correct Jewish month lengths correctly.