refactor: bup eslint-plugin-unicorn, fix linting

package.json

@@ -80,7 +80,7 @@
   "dependencies": {
     "@aws-sdk/client-lambda": "^3.414.0",
     "@hapi/boom": "^10.0.1",
-    "@hapi/h2o2": "^10.0.3",
+    "@hapi/h2o2": "^10.0.4",
     "@hapi/hapi": "^21.3.2",
     "@serverless/utils": "^6.15.0",
     "array-unflat-js": "^0.1.3",
@@ -111,7 +111,7 @@
     "eslint-config-prettier": "^9.0.0",
     "eslint-plugin-import": "^2.28.1",
     "eslint-plugin-prettier": "^5.0.0",
-    "eslint-plugin-unicorn": "^46.0.1",
+    "eslint-plugin-unicorn": "^48.0.1",
     "git-list-updated": "^1.2.1",
     "husky": "^8.0.3",
     "lint-staged": "^14.0.1",

src/ServerlessOffline.js

@@ -261,13 +261,13 @@ export default class ServerlessOffline {
 
     // Parse CORS options
     this.#options.corsAllowHeaders = this.#options.corsAllowHeaders
-      .replace(/\s/g, '')
+      .replaceAll(' ', '')
       .split(',')
     this.#options.corsAllowOrigin = this.#options.corsAllowOrigin
-      .replace(/\s/g, '')
+      .replaceAll(' ', '')
       .split(',')
     this.#options.corsExposedHeaders = this.#options.corsExposedHeaders
-      .replace(/\s/g, '')
+      .replaceAll(' ', '')
       .split(',')
 
     this.#options.corsConfig = {

src/events/authMatchPolicyResource.js

@@ -61,7 +61,7 @@ export default function authMatchPolicyResource(policyResource, resource) {
     // for the requested resource and the resource defined in the policy
     // Need to create a regex replacing ? with one character and * with any number of characters
     const regExp = new RegExp(
-      parsedPolicyResource.path.replace(/\*/g, '.*').replace(/\?/g, '.'),
+      parsedPolicyResource.path.replaceAll('*', '.*').replaceAll('?', '.'),
     )
 
     return regExp.test(parsedResource.path)

src/events/http/Endpoint.js

@@ -17,7 +17,7 @@ const defaultResponseTemplate = readFileSync(
 
 function getResponseContentType(fep) {
   if (fep.response && fep.response.headers['Content-Type']) {
-    return fep.response.headers['Content-Type'].replace(/'/gm, '')
+    return fep.response.headers['Content-Type'].replaceAll(/'/gm, '')
   }
 
   return 'application/json'

src/events/http/javaHelpers.js

@@ -20,10 +20,6 @@ function javaMatches(value) {
   return this.match(new RegExp(value, 'm'))
 }
 
-function javaReplaceAll(oldValue, newValue) {
-  return this.replace(new RegExp(oldValue, 'gm'), newValue)
-}
-
 function javaReplaceFirst(oldValue, newValue) {
   return this.replace(new RegExp(oldValue, 'm'), newValue)
 }
@@ -74,7 +70,6 @@ const {
     equalsIgnoreCase,
     matches,
     regionMatches,
-    replaceAll,
     replaceFirst,
   },
 } = String
@@ -85,7 +80,6 @@ export default function runInPollutedScope(runScope) {
   prototype.equalsIgnoreCase = javaEqualsIgnoreCase
   prototype.matches = javaMatches
   prototype.regionMatches = javaRegionMatches
-  prototype.replaceAll = javaReplaceAll
   prototype.replaceFirst = javaReplaceFirst
 
   const result = runScope()
@@ -95,7 +89,6 @@ export default function runInPollutedScope(runScope) {
   prototype.equalsIgnoreCase = equalsIgnoreCase
   prototype.matches = matches
   prototype.regionMatches = regionMatches
-  prototype.replaceAll = replaceAll
   prototype.replaceFirst = replaceFirst
 
   return result

src/events/http/lambda-events/VelocityContext.js

@@ -14,7 +14,7 @@ const { assign, entries, fromEntries } = Object
 
 function escapeJavaScript(x) {
   if (typeof x === 'string') {
-    return jsEscapeString(x).replace(/\\n/g, '\n') // See #26,
+    return jsEscapeString(x).replaceAll('\\n', '\n') // See #26,
   }
 
   if (isPlainObject(x)) {
@@ -136,7 +136,7 @@ export default class VelocityContext {
           Buffer.from(x.toString(), 'binary').toString('base64'),
         escapeJavaScript,
         parseJson: parse,
-        urlDecode: (x) => decodeURIComponent(x.replace(/\+/g, ' ')),
+        urlDecode: (x) => decodeURIComponent(x.replaceAll('+', ' ')),
         urlEncode: encodeURI,
       },
     }

src/events/schedule/ScheduleEvent.js

@@ -16,7 +16,7 @@ export default class ScheduleEvent {
   source = 'aws.events'
 
   // format of aws displaying the time, e.g.: 2020-02-09T14:13:57Z
-  time = new Date().toISOString().replace(/\.(.*)(?=Z)/g, '')
+  time = new Date().toISOString().replaceAll(/\.(.*)(?=Z)/g, '')
 
   version = '0'
 

src/utils/generateHapiPath.js

@@ -15,7 +15,7 @@ export default function generateHapiPath(path, options, serverless) {
     hapiPath = hapiPath.slice(0, -1)
   }
 
-  hapiPath = hapiPath.replace(/\+}/g, '*}')
+  hapiPath = hapiPath.replaceAll('+}', '*}')
 
   return hapiPath
 }