Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for hamlib4 #14

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

update for hamlib4 #14

wants to merge 6 commits into from

Conversation

dl1igc
Copy link

@dl1igc dl1igc commented Jan 8, 2022

With this changes this library is able to compile against libham4. Basic function works with FTDX3000.

@xylo04
Copy link
Contributor

xylo04 commented Jan 10, 2022

Since this isn't backward compatible with hamlib 3.x, goHamlib will need a v2 branch. I support doing this.

@dh1tw
Copy link
Owner

dh1tw commented Jan 10, 2022

Hey @dl1igc, thanks for your PR! Very much appreciated. I share the concerns with @xylo04 and I think we should investigate if there is a way to maintain the compatibility with Hamlib 3. We will have to compare what has exactly changed between Hamlib v3 and v4. Maybe we could maintain compatibility with a few additional if/else statements. A v2 branch, as suggested by @xylo04 should be IMHO the last option.

@dl1igc
Copy link
Author

dl1igc commented Jan 13, 2022

Thanks for your comments @xylo04 and @dh1tw. I can understand your concerns and share them. If I am not wrong, we have two different compatibility levels. We could probably do the golang code compatible to both libham version over preprocessor directives (#ifdefs and so) but this does not mean that the compiled version will be compatible with both libham versions, I am at the moment not sure that this will work. At the end I think this situation would be even more confusing for end users. I'll give this some deeper thought over the weekend.

@xylo04 xylo04 mentioned this pull request Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants