add test to ensure calling set after close does not panic #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Wait some more time so Set can run a few additional times. | ||
| tcd := time.Tick(250 * time.Millisecond) | ||
| <-tcd | ||
| close(done) |
There was a problem hiding this comment.
@joshua-goldstein Is there some state that can be checked to see if the test succeeded? Other than the check of err on the creation of NewCache, there's no other way the test can fail, right? Or perhaps the previous panic is the only error condition.
There was a problem hiding this comment.
The idea behind the test is that if the bug exists, the race detector will raise a panic (thus breaking the test)
joshua-goldstein
force-pushed
the
joshua/add-test
branch
from
73b0545
to
f502498
Compare
mangalaman93
requested review from
mangalaman93 and
harshil-goel
as code owners
mangalaman93
force-pushed
the
joshua/add-test
branch
from
f502498
to
62032db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a prior version of Ristretto, calling set after close could cause a panic. We are adding this test to check for this behavior and prevent a regression. Test was originally written by @josephschorr in this PR.