New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Update caching mechanism of posting lists #9068
Open
harshil-goel
wants to merge
15
commits into
main
Choose a base branch
from
harshil-goel/mem-cache
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgraph-bot
added
area/testing
Testing related issues
area/core
internal mechanisms
go
Pull requests that update Go code
labels
Apr 8, 2024
harshil-goel
force-pushed
the
harshil-goel/mem-cache
branch
from
April 18, 2024 13:52
f58b1ab
to
f52b96e
Compare
harshil-goel
commented
Apr 26, 2024
posting/mvcc.go
Outdated
// corresponding to the key in the cache to nil. So, if we get some non-nil value from the cache | ||
// then it means that no writes have happened after the last set of this key in the cache. | ||
if l, ok := countMap.list[string(key)]; ok { | ||
if l != nil && l.maxTs < readTs { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l.minTs < readTs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/core
internal mechanisms
area/testing
Testing related issues
go
Pull requests that update Go code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title format:
Topic(Area): Feature
Topic
must be one ofbuild|ci|docs|feat|fix|perf|refactor|chore|test
Area
must be one ofacl|audit|backup|badger|cdc|dql|export|graphql|indexing|multi-tenancy|raft|restore|upgrade|zero
Body Format:
Description:
Fixes:
Closes:
Docs: