Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(acl): fix duplicate groot user creation #9041

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mangalaman93
Copy link
Contributor

@mangalaman93 mangalaman93 commented Mar 1, 2024

This PR adds the unique directive to the 'dgraph.xid' predicate. Prior to this change, users could create duplicate users leading to misconfiguration of ACL.

@mangalaman93 mangalaman93 requested a review from a team as a code owner March 1, 2024 06:52
@dgraph-bot dgraph-bot added area/testing Testing related issues area/enterprise Related to proprietary features area/schema Issues related to the schema language and capabilities. area/graphql Issues related to GraphQL support on Dgraph. area/enterprise/acl Related to Access Control Lists area/core internal mechanisms go Pull requests that update Go code labels Mar 1, 2024
@mangalaman93 mangalaman93 changed the title fix(acl): fix duplicate groot user creation (#51) fix(acl): fix duplicate groot user creation Mar 1, 2024
testutil/client.go Outdated Show resolved Hide resolved
systest/integration2/acl_test.go Outdated Show resolved Hide resolved
dgraphtest/paths.go Outdated Show resolved Hide resolved
dgraphtest/ee.go Outdated Show resolved Hide resolved
dgraphtest/ee.go Outdated Show resolved Hide resolved
check_upgrade/check_upgrade.go Outdated Show resolved Hide resolved
check_upgrade/check_upgrade.go Show resolved Hide resolved
check_upgrade/check_upgrade.go Outdated Show resolved Hide resolved
check_upgrade/check_upgrade.go Outdated Show resolved Hide resolved
check_upgrade/check_upgrade.go Outdated Show resolved Hide resolved
@shivaji-dgraph shivaji-dgraph force-pushed the aman/8c968c891 branch 2 times, most recently from 6b76bc6 to fcfddbe Compare March 27, 2024 13:55
check_upgrade/check_upgrade.go Outdated Show resolved Hide resolved
check_upgrade/check_upgrade.go Show resolved Hide resolved
check_upgrade/check_upgrade.go Outdated Show resolved Hide resolved
dgraphtest/paths.go Outdated Show resolved Hide resolved
check_upgrade/check_upgrade.go Outdated Show resolved Hide resolved
check_upgrade/check_upgrade.go Outdated Show resolved Hide resolved
check_upgrade/check_upgrade.go Show resolved Hide resolved
check_upgrade/check_upgrade.go Outdated Show resolved Hide resolved
check_upgrade/check_upgrade.go Show resolved Hide resolved
check_upgrade/check_upgrade.go Outdated Show resolved Hide resolved
check_upgrade/check_upgrade.go Outdated Show resolved Hide resolved
check_upgrade/check_upgrade.go Show resolved Hide resolved
check_upgrade/check_upgrade.go Show resolved Hide resolved
check_upgrade/check_upgrade.go Outdated Show resolved Hide resolved
check_upgrade/dgraph.go Outdated Show resolved Hide resolved
testutil/client.go Outdated Show resolved Hide resolved
shivaji-dgraph and others added 2 commits April 23, 2024 10:47
This PR adds the unique directive to the 'dgraph.xid' predicate. Prior to this change, users could
create duplicate users leading to misconfiguration of ACL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core internal mechanisms area/enterprise/acl Related to Access Control Lists area/enterprise Related to proprietary features area/graphql Issues related to GraphQL support on Dgraph. area/schema Issues related to the schema language and capabilities. area/testing Testing related issues go Pull requests that update Go code
Development

Successfully merging this pull request may close these issues.

None yet

3 participants