perf(query): Read just the latest value for scalar types #8966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshil-goel
requested review from
mangalaman93,
meghalims,
sanjayk-github-dev,
all-seeing-code,
billprovince and
joshua-goldstein
as code owners
dgraph-bot
added
area/testing
harshil-goel
force-pushed
the
harshil-goel/single_key
branch
from
53ec545
to
3a2f444
Compare
harshil-goel
changed the title
harshil-goel
force-pushed
the
harshil-goel/single_key
branch
3 times, most recently
from
8e0dc79
to
191f210
Compare
harshil-goel
force-pushed
the
harshil-goel/single_key
branch
from
191f210
to
2a07e8b
Compare
jairad26
reviewed
Sep 15, 2023
posting/lists.go
Outdated
|
|
||
| pl, err := getPostings() | ||
| if err == badger.ErrKeyNotFound { | ||
| err = nil |
worker/task.go
Outdated
| @@ -376,6 +376,9 @@ func (qs *queryState) handleValuePostings(ctx context.Context, args funcArgs) er | |||
|
|
|||
| outputs := make([]*pb.Result, numGo) | |||
| listType := schema.State().IsList(q.Attr) | |||
| hasLang := schema.State().HasLang(q.Attr) | |||
| getMultiplePosting := q.DoCount || q.ExpandAll || listType || hasLang | |||
| //getMultiplePosting := true | |||
| @@ -195,6 +195,59 @@ func (lc *LocalCache) getInternal(key []byte, readFromDisk bool) (*List, error) | |||
| return lc.SetIfAbsent(skey, pl), nil | |||
| } | |||
|
|
|||
| func (lc *LocalCache) GetSinglePosting(key []byte) (*pb.PostingList, error) { | |||
There was a problem hiding this comment.
since its a public function could you add a description of what this function's doing/why its necessary? basically what you explained yesterday in text format would be helpful for future reference
posting/lists.go
Outdated
| return pl, nil | ||
| } | ||
| } | ||
| lc.RUnlock() |
There was a problem hiding this comment.
why not defer unlock till the end of the function?
harshil-goel
force-pushed
the
harshil-goel/single_key
branch
2 times, most recently
from
d572cae
to
29cb753
Compare
mangalaman93
requested changes
Oct 11, 2023
worker/task.go
Outdated
| @@ -376,6 +376,9 @@ func (qs *queryState) handleValuePostings(ctx context.Context, args funcArgs) er | |||
|
|
|||
| outputs := make([]*pb.Result, numGo) | |||
| listType := schema.State().IsList(q.Attr) | |||
| hasLang := schema.State().HasLang(q.Attr) | |||
| getMultiplePosting := q.DoCount || q.ExpandAll || listType || hasLang | |||
posting/list_test.go
Outdated
| require.NoError(t, err) | ||
| checkValue(t, ol, string(k.Postings[0].Value), uint64(j)) | ||
| } | ||
|
|
harshil-goel
force-pushed
the
harshil-goel/single_key
branch
2 times, most recently
from
80102bb
to
e893711
Compare
harshil-goel
changed the title
mangalaman93
previously approved these changes
Oct 13, 2023
harshil-goel
dismissed
mangalaman93’s stale review
The base branch was changed.
added 13 commits
October 13, 2023 22:12
harshil-goel
force-pushed
the
harshil-goel/single_key
branch
from
e893711
to
0ce037c
Compare
jairad26
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Right now, when we read some data, we read the entire posting list. With this we populate List structure in memory, which has two layers. These two layers are then merge sorted. All of this takes a lot of time. In this diff, we are updating the query processor to just read the latest value in case of scalar types.
LDBC test for IC09.
Before: 35 seconds
After: 26 seconds