Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(upgrade): add upgrade tests for systest/ldbc #8933

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

test(upgrade): add upgrade tests for systest/ldbc #8933

wants to merge 4 commits into from

Conversation

jbhamra1
Copy link
Contributor

@jbhamra1 jbhamra1 commented Aug 4, 2023 •
edited

@dgraph-bot dgraph-bot added area/testing Testing related issues go Pull requests that update Go code labels Aug 4, 2023
@jbhamra1 jbhamra1 changed the title Upgrade changes for systest/ldbc using dgraphtest framework Upgrade test changes for systest/ldbc Aug 4, 2023
@mangalaman93 mangalaman93 mentioned this pull request Aug 11, 2023
Closed
@jbhamra1 jbhamra1 marked this pull request as ready for review August 17, 2023 07:08
@jbhamra1 jbhamra1 force-pushed the jassi/systest_ldbc branch 3 times, most recently from 30254f0 to db84295 Compare August 21, 2023 18:25
@all-seeing-code
Copy link
Contributor

@jbhamra1 This is failing on CI. I also had questions:

  1. I was under the impression that we were transitioning away from alpha.yml in favor of using the dgraphtest package to spin up the cluster. Could you please clarify?
  2. Would you mind updating the description in the PR? It would be great to have a clearer understanding of the changes being made, the reasons behind them, and so on. I always find it helpful to grasp the overall intention and purpose of the PR in simple terms before diving into the code for a detailed review. Thank you!

@jbhamra1 jbhamra1 changed the title Upgrade test changes for systest/ldbc test(upgrade): add upgrade tests for systest/ldbc Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mangalaman93 mangalaman93 Awaiting requested review from mangalaman93

@meghalims meghalims Awaiting requested review from meghalims

@sanjayk-github-dev sanjayk-github-dev Awaiting requested review from sanjayk-github-dev

@harshil-goel harshil-goel Awaiting requested review from harshil-goel

@all-seeing-code all-seeing-code Awaiting requested review from all-seeing-code

@billprovince billprovince Awaiting requested review from billprovince

@joshua-goldstein joshua-goldstein Awaiting requested review from joshua-goldstein

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/testing Testing related issues go Pull requests that update Go code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbhamra1 @all-seeing-code @dgraph-bot