Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for custom headers #32

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

arjuninv
Copy link
Contributor

@arjuninv arjuninv commented Oct 6, 2020

Added support for adding custom headers after creating a ClientStub object.

Reason
To be able to add headers such as auth tokens from third party authentication services that may not necessarily be available at the time of creation of the ClientStub and Client object.


This change is Reviewable

@@ -55,7 +55,7 @@ export class DgraphClientStub {
}

this.options = options;

this.options.header = {};
Copy link
Contributor

@paulftw paulftw Oct 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would erase options.headers if it exists.
Something that clients may rely on, e.g. Ratel

if (this.options.headers === undefined) {
 this.options.headers = {};
}

would be much safer and backwards compatible

src/types.ts Show resolved Hide resolved
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants