Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs(Enterprise): Notify that offline restore feature is deprecated #318

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kevinmingtarja
Copy link
Contributor

@kevinmingtarja kevinmingtarja commented Oct 19, 2022

Description:

The offline restore feature is deprecated (v21.03.0 was the last version to have it), but it is not stated in the docs, which might confuse readers. So, I think we should do something to notify of this change.

@skrdgraph
Copy link
Contributor

@kevinmingtarja it would be good to point to the dgraph code / commit where this was deprecated.

@MichelDiz this is exactly the reason why docs & code should go together

@skrdgraph skrdgraph self-requested a review October 19, 2022 17:18
@kevinmingtarja
Copy link
Contributor Author

kevinmingtarja commented Oct 19, 2022

@skrdgraph Actually after further digging, I found these two slack threads, and from these two it seems like they only deprecated it in a separate release branch for cloud release/v21.03-slash (https://github.com/dgraph-io/dgraph/commits/release/v21.03-slash). I'm still trying to find the exact commit where the change happened. It's also possible that they did not end up bringing the changes from this cloud branch to the actual v21.03. I'll let you know if I find anything.

https://dgraphlabs.slack.com/archives/C019WF554MB/p1619198987277300

https://dgraphlabs.slack.com/archives/CSH96QK62/p1621279945315600?thread_ts=1621278898.313900&cid=CSH96QK62

@skrdgraph
Copy link
Contributor

@kevinmingtarja we will skip it for the current doc release, and we can always add this in next week as a fix to our released docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants